Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

Fix failing e2e tests #3850

Merged
merged 4 commits into from
Apr 25, 2024
Merged

Fix failing e2e tests #3850

merged 4 commits into from
Apr 25, 2024

Conversation

PetarTodorovv
Copy link
Collaborator

@PetarTodorovv PetarTodorovv commented Apr 24, 2024

Description
This PR fixes the failing tests that are related to the below-mentioned PRs/changes.

Also, there are two failing tests NOT related to the mentioned PRs - TestConsumerProviderFlow and Create_a_destination_associated_with_a_bundle_using_existing_destinations_created_from_destination_creator, these tests are added/changed in the PR #3681 and will still fail. They need to be further investigated.

Changes proposed in this pull request:

  • Adaptations and fixes for the different http/graphql clients and tenants that were used.

Related issue(s)

Pull Request status

  • Implementation
  • Unit tests
  • Integration tests
  • chart/compass/values.yaml is updated
  • Mocks are regenerated, using the automated script

@PetarTodorovv PetarTodorovv requested review from a team as code owners April 24, 2024 15:02
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 24, 2024
@PetarTodorovv PetarTodorovv added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2024
emmakarova
emmakarova previously approved these changes Apr 24, 2024
@kyma-bot kyma-bot added lgtm Looks good to me! approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 24, 2024
@kyma-bot kyma-bot added 🦖 team-raptor Team Raptor Label size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Looks good to me! approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 25, 2024
@PetarTodorovv PetarTodorovv removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2024
emmakarova
emmakarova previously approved these changes Apr 25, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 25, 2024
@kyma-bot
Copy link

kyma-bot commented Apr 25, 2024

@PetarTodorovv: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-compass-gke-benchmark 69943c3 link false /test pre-main-compass-gke-benchmark

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

la4ezar
la4ezar previously approved these changes Apr 25, 2024
@kyma-bot kyma-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2024
@PetarTodorovv PetarTodorovv dismissed stale reviews from la4ezar and emmakarova via 2cb7cb9 April 25, 2024 07:12
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Apr 25, 2024
@kyma-bot kyma-bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 25, 2024
@kyma-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: emmakarova, la4ezar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyma-bot kyma-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2024
@kyma-bot kyma-bot merged commit 37b0ed2 into main Apr 25, 2024
5 of 6 checks passed
@la4ezar la4ezar deleted the fix-failing-tests branch April 25, 2024 08:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files. 🦖 team-raptor Team Raptor Label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants