Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

Adapt ORD Service change #3809

Merged
merged 5 commits into from
Apr 15, 2024
Merged

Adapt ORD Service change #3809

merged 5 commits into from
Apr 15, 2024

Conversation

nyordanoff
Copy link
Contributor

@nyordanoff nyordanoff commented Apr 11, 2024

Description

Adaptation of this ORD Service PR

In addition, the smoke test and ord e2e tests had to be slightly adapted because there the resources (Apps, Bundles, Apis, Events) are created via gql queries which don't include some required ORD fields. That's why in the odata query we select only fields that are present.

Related issue(s)

Pull Request status

  • Implementation
  • Unit tests
  • Integration tests
  • chart/compass/values.yaml is updated
  • Mocks are regenerated, using the automated script

@nyordanoff nyordanoff requested review from a team as code owners April 11, 2024 15:11
@nyordanoff nyordanoff added the 🦖 team-raptor Team Raptor Label label Apr 11, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 11, 2024
@nyordanoff nyordanoff added 👋 request review Review required and removed cla: yes Indicates the PR's author has signed the CLA. labels Apr 11, 2024
@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 11, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 11, 2024
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 12, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 12, 2024
@nyordanoff
Copy link
Contributor Author

/hold

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2024
@kyma-bot
Copy link

kyma-bot commented Apr 12, 2024

@nyordanoff: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-compass-gke-benchmark 2b0cae6 link false /test pre-main-compass-gke-benchmark

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nyordanoff
Copy link
Contributor Author

/test pre-main-compass-integration-no-dump

@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 15, 2024
@kyma-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: la4ezar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyma-bot kyma-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2024
@nyordanoff
Copy link
Contributor Author

/hold cancel

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2024
@kyma-bot kyma-bot merged commit 6ad1b16 into main Apr 15, 2024
5 of 7 checks passed
@nyordanoff nyordanoff deleted the ord-nullable-fields branch April 15, 2024 08:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files. 🦖 team-raptor Team Raptor Label 👋 request review Review required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants