Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

Support Data Center aggregation by default when auto-discovering system tenants #3778

Merged
merged 13 commits into from
Apr 17, 2024
Merged

Support Data Center aggregation by default when auto-discovering system tenants #3778

merged 13 commits into from
Apr 17, 2024

Conversation

NickyMateev
Copy link
Member

Support Data Center aggregation by default when auto-discovering system tenants

Add configuration which enables the aggregation of data center information (in the form of label on our side) when auto-discovering system tenants.

@NickyMateev NickyMateev requested review from a team as code owners March 28, 2024 12:12
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 28, 2024
@NickyMateev
Copy link
Member Author

/test pre-main-compass-integration-no-dump

@NickyMateev NickyMateev added the 👋 request review Review required label Mar 29, 2024
@alextargov alextargov added the 🦅 team-falcon Team Falcon Label label Mar 29, 2024
dragobt
dragobt previously approved these changes Apr 1, 2024
View reviewed changes
@kyma-bot kyma-bot added lgtm Looks good to me! approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 1, 2024
@NickyMateev
Copy link
Member Author

/retest

@NickyMateev
Copy link
Member Author

/test pre-main-compass-integration-no-dump

@kyma-bot kyma-bot removed lgtm Looks good to me! approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 2, 2024
@NickyMateev
Copy link
Member Author

/retest

2 similar comments
@NickyMateev
Copy link
Member Author

/retest

@NickyMateev
Copy link
Member Author

/retest

dragobt
dragobt previously approved these changes Apr 3, 2024
View reviewed changes
@kyma-bot kyma-bot added lgtm Looks good to me! approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 3, 2024
@NickyMateev
Copy link
Member Author

/retest

@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Looks good to me! approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 4, 2024
@NickyMateev
Copy link
Member Author

/test pre-main-compass-integration-no-dump

@NickyMateev
Copy link
Member Author

/retest

@NickyMateev
Copy link
Member Author

/retest

@NickyMateev
Copy link
Member Author

/retest

1 similar comment
@NickyMateev
Copy link
Member Author

/retest

@kyma-bot
Copy link

kyma-bot commented Apr 17, 2024 •
edited
Loading

@NickyMateev: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-compass-gke-benchmark f329eb6 link false /test pre-main-compass-gke-benchmark

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@NickyMateev
Copy link
Member Author

/retest

@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 17, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 17, 2024
@kyma-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: emmakarova

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyma-bot kyma-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2024
@kyma-bot kyma-bot merged commit a32c48d into main Apr 17, 2024
5 of 6 checks passed
@NickyMateev NickyMateev deleted the data-center-aggrregation-support branch April 18, 2024 05:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emmakarova emmakarova emmakarova approved these changes

@dragobt dragobt dragobt left review comments

@nyordanoff nyordanoff Awaiting requested review from nyordanoff

@StefanCholakov StefanCholakov Awaiting requested review from StefanCholakov

Assignees

@emmakarova emmakarova

@dragobt dragobt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. 🦅 team-falcon Team Falcon Label lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files. 👋 request review Review required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NickyMateev @kyma-bot @emmakarova @dragobt @alextargov