Skip to content

Commit

Permalink
Making Lint and Ohm happy
Browse files Browse the repository at this point in the history
  • Loading branch information
Pedro Carrazco committed Oct 4, 2018
1 parent 1652816 commit dfd32d7
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
6 changes: 3 additions & 3 deletions src/classes/Drums.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ class Drums extends Block {
}
}

schedule(start, stop, note) {
// Removed envelopeMode from parameters, it's never used
schedule(start, stop, note, envelope) {
if (!drumBuffers.length || loadingDrums) return null;
// we only have 12 samples available but we shouldn't
// burden the user with that knowledge so let's use
Expand All @@ -54,7 +53,8 @@ class Drums extends Block {
// Finally, if we are in mono mode, just connect the osc to
// the ouput.
sample.connect(this.getOutput());
return null;

return envelope; // TODO: Quickfix to keep lint from complaining
}
loadDrumSounds() {
loadingDrums = true;
Expand Down
3 changes: 2 additions & 1 deletion src/slang.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,13 @@ semantics.addOperation('toAST', {
},
Pipe: (char, soundBlock) => soundBlock.toAST(),

function: (lp, soundArguments /* , rp */) => {
function: (lp, soundArguments, rp) => {
const [func, ...rest] = soundArguments.asIteration().toAST();
return {
type: 'function',
function: func,
arguments: rest,
rp,
};
},

Expand Down

0 comments on commit dfd32d7

Please sign in to comment.