Cleanup some tests and documentation #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Clean-up processes properly.
* Instead encourage the user to change how they invoke docker.
* It's fine for these to fail, it's expected.
* Fix all the test to not require this flag.
* Fix all the docs to not mention this flag.
* This is really hard to work on other things while running this test when the host networking stack is being manipulated, primarily the default route. * Propagate DEBUG flag deeper where possible.
kylemanna
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Localize a lot of the testing by dropping things like
--privilegedand--net=hostto make testing safer and approach of least privilege.--net=hosteverywhere - this terrorized my dev machine.--privilegedthis isn't really needed other then messing withsysctlvalues. Warnings are printed now.iptableschecks.DEBUGenvironment variable deeper to help debugging.