CEL RelatedResourceFilter implementations #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Unit tests for all 4 new CEL filters supported
… unit test to access related resource values besides tags
…low to use CEL & RelatedResource access for Security Configurations
…ific CELFilter classes
…and Lambda to use this
…on to DynamoDB tables
…on to Backup Vault resources
…on to Redshift resources
…on to Elasticache resources
…on for Elasticsearch resources
…on for DMS Instance resources
…for EMR resources
…for Redshift resources
…for MQ Message Broker resources
…for EKS Cluster resources
…get_related_subnets() for HSM Cluster resources
…for Directory resources
…for Elasticache Cluster resources
…for DAX Cluster resources
Implement SG Usage CEL filter
…Replication Instance resources
…Cluster resources
… Build Project resources
…ticsearch Domain resources
…e Table resources
…Endpoint resources
…used}_snapshots()
…oles() for IAM Role resources
…nused}_iam_profiles() for IAM Instance Profile resources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains CEL support to the child classes that extend the core
RelatedResourceFilter.The following child classes of
RelatedResourceFilterare supported in this PR:I plan to open another PR for the remaining to fully support
RelatedResourceFilter. The remaining classes include:Some of these resource-specific implementations for related resources are dependent on changes in c7nlib via cloud-custodian/cel-python#18 to pull related resources.
Also waiting on cloud-custodian/cel-python#19 to updated CEL's
activationfields to be more Pythonic. Once that's merged in, this PR will need updated to reflect those new expectations, but that's a super easy fix.