fix: solve the lock due to promise returned in a promise #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when scanDir was called, it was returning a promise thant calls scanFiles. But scanFiles returns a promise also. Solved by awaiting the return of scanFiles call and resolving correctly the promise of scanDir.
|
Excellent. I'll give this PR a spin and make sure everything is kosher. Not sure why the test suite didn't pick this issue up so I may need to add a new test or adjust a current one to make sure the intended functionality is working as expected from here on out. |
|
Fixes #87 |
|
For the record, this fix was pushed out in v2.1.1. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when scanDir was called, it was returning a promise that calls scanFiles. But scanFiles returns a promise also. Solved by awaiting the return of scanFiles call and resolving correctly the promise of scanDir.