Update to support building with Swift 4.2 #37
Conversation
|
CI is failing until Swift 4.2 is released |
Package.swift
Outdated
| @@ -11,5 +11,6 @@ let package = Package( | |||
| targets: [ | |||
| .target(name: "Spectre", dependencies: []), | |||
| .testTarget(name: "SpectreTests", dependencies: ["Spectre"]), | |||
| ] | |||
| ], | |||
| swiftLanguageVersions: [.v4, .v4_2] | |||
There was a problem hiding this comment.
Would this break support on 4.0 because it would have no idea about the .4_2 enumeration?
There was a problem hiding this comment.
v4 doesn't include 4.2?
If you don't add 4.2 explicitly SwiftPM will assume 4 only
Would this break support on 4.0 because it would have no idea about the .4_2 enumeration?
It depends on what you mean by 4.0 here. It will require the Swift 4.2 (or newer) compiler, but it can still compile with Swift 4.0 syntax. Alternatively I can create a new [email protected] file, and not touch this one, to support both simultaneously going forward.
There was a problem hiding this comment.
Updated with the new file instead
|
With this new file this would actually be fine to merge before the official release, if we could get CI to pass |
|
I reverted my CI changes for now |
This likely shouldn't be merged until Swift 4.2 is officially released (hopefully this week)