swift 4 changes

[ghost]

I'm guessing we should tag the merge with a version of 0.8.0, ¿yeah?

[ghost]

looks like swiftenv isn't ready for Swift 4 yet

We don't have build instructions for 4.0.
The command "eval "$(curl -sL https://gist.githubusercontent.com/kylef/5c0475ff02b7c7671d2a/raw/9f442512a46d7a2af7b850d65a7e9bd31edfb09b/swiftenv-install.sh)"" failed and exited with 1 during .

[kylef]

looks like swiftenv isn't ready for Swift 4 yet

Well, Swift 4 isn't out yet... Perhaps you meant to use a dev snapshot 4.0 such as 4.0-DEVELOPMENT-SNAPSHOT-2017-06-07-a?

[ghost]

yes indeed, i was in some weird state where 4.0 was a valid version locally, i don't know how that happened but i later ran into the same issue as the CI and resolved it by doing just that.

[ghost]

passes now 😄

[ghost]

This should probably not merge into master until 4.0 is nailed down, ¿will you make a swift-4 branch so I can make a PR to that instead?

[kylef]

Hi @CalQL8ed-K-OS I was wondering if it is possible to make the code compatible with both versions of Swift (3.1.1 and 4 Snapshot). That way we can mere this into master so a release of Spectre will work with both.

[ehyche]

@kylef : any update on getting this PR merged?

[kylef]

@ehyche Once my feedback (#27 (comment)) is addressed I'll merge this.

[ehyche]

@kylef : I am not sure about the changes in .swift-version, but in my PR that I closed I made essentially the same changes and I verified that they worked on both Xcode 8 (Swift 3.2) and Xcode 9 (Swift 4).

[Bersaelor]

@ehyche @kylef
For SwiftPM you could tag versions on different branches with 0.8.0 vs 0.8.0@swift-4.

(or have a 0.8.0@swift-3 on a legacy swift3.1 branch and the 0.8.0 for Swift-4 on main master)

Looking forward to have the swift4 version of your amazing project :)
(Less warnings in my Kitura-App!)

[kylef]

Merged this in 0fd38db