Only use red color for errors if terminal supports ANSI #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylef
approved these changes
Nov 25, 2017
|
Tried to fix merge conflict with GitHub UI and then GitHub got into some odd unmergable state. Merged changes in manually via d08cd61. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some places in the code where ANSI codes where printed to
stderrwithout testing if the terminal supported it.This made error messages in the Xcode console for example to print the ANSI escapes — as the Xcode console doesn't support ANSI color codes
This change allows to print a string in a given color on
stderrorstdoutonly if the terminal supports it.