Move off bower #189
Open
Move off bower #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 8, 2018 22:43
I just perfer to see the dependancies at the bottom as they can tend to grow and it makes it easier to view the more important stuff like meta info about the package and the scripts in a terminal editor if they are at the top
This change set removes 🔥 Bower as the dependancy package manager and switches over to NPM. Bower requiers all packages to be in git and pulls them out of a public git repo. NPM on the other hand is a registry of packages and it has become the go to for JS package dependancy for both Node and Browser applications. The Bower website even suggests moving off Bower in favor of NPM/Yarn.
With the change to move off bower I had to update angular-smart-table because NPM did not have the very old version we were using. The oldest 1.x version it had was 1.4.12. In angular-smart-table 1.4.2 however they refactored their smart-table.module.js file to no longer pass in the angular global but instead refernce the ng variable directly. This caused an issue with the Karma config as ng is unknown. Looking at lorenzofox3/Smart-Table@13da8c9#diff-40dfb1c53004f1488cbe6eb300b286dd I see what they did for their Karma test config so this change set is just copying that to ensure that the angular-smart-table module is imported propertly in the tests. This does not seem to be an issue in prod.
|
It is critical to have this PR merged in order to be able to build the image on your own, dependencies on bower repository are broken! Here i show a build intent using branch v2
Here i show a build intent using branch v2-stable (a custom one i made with this PR and a couple more merged https://github.com/xoxefdp/docker-registry-frontend/tree/v2-stable)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change set removes 🔥 Bower as the dependancy package manager and
switches over to NPM. Bower requires all packages to be in git and pulls
them out of a public git repo. NPM on the other hand is a registry of
packages and it has become the go to for JS package dependancy for both
Node and Browser applications. The Bower website even suggests moving
off Bower in favour of NPM/Yarn.
I chose to go with NPM over Yarn as currently NPM offers more features then Yarn and is reported as being faster then Yarn now.