Added centos based dockerfile for UI and cccp.yml #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purpose of cccp.yml is to build this on the CentOS Container Pipeline. Signed-off-by: Mohammed Zeeshan Ahmed <[email protected]>
|
@kwk ping |
kwk
requested changes
Jul 27, 2017
There was a problem hiding this comment.
@mohammedzee1000 I cannot test this properly. Also, why to you copy paste most of the stuff instead of re-factoring the old Dockerfile or start script? This duplication of code makes it not possible for me to maintain.
For example, what is wrong with: a2enmod ssl? Does that not exist on CentOS? If it doesn't then please refactor the main Dockerfile to use something other than debian:jessie. But lets just have just one Dockerfile to maintain.
|
@kwk ok understood, will do the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of cccp.yml is to build this on the CentOS
Container Pipeline.
Signed-off-by: Mohammed Zeeshan Ahmed [email protected]