fix crash on invalid snapshot #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchappelow
previously approved these changes
Jun 26, 2024
|
LoadSnapshotChunk has the Open problem too. That method I believe is called on demand by peers, so DOS |
jchappelow
reviewed
Jun 26, 2024
charithabandi
approved these changes
Jun 27, 2024
|
Looks good! |
brennanjl
added a commit
that referenced
this pull request
Jun 27, 2024
* fix crash on invalid snapshot * smarter snapshot chunk loading --------- Co-authored-by: Jonathan Chappelow <[email protected]>
brennanjl
added a commit
that referenced
this pull request
Jun 27, 2024
* fix crash on invalid snapshot * smarter snapshot chunk loading --------- Co-authored-by: Jonathan Chappelow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue where I stopped by node at just the right time where it was able to get bricked and become unrecoverable without manual intervention. While creating a snapshot, my node stopped, and was then unable to restart. It would crash on restart due to a nil pointer dereference. This PR fixes this.