Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build,scripts: use non-experimental golang docker image #562

Merged
merged 4 commits into from
Feb 29, 2024

Conversation

jchappelow
Copy link
Member

golang:alpine docker image is "highly experimental, and not officially supported by the Go project" according to https://hub.docker.com/_/golang and golang/go#19938
As a test, this switches to the official and versioned golang docker image. This is a much larger docker image, but it is only used for building the kwild image. The size of our published kwild image is unchanged.

@jchappelow jchappelow changed the title [TEST] build,scripts: use non-experimental golang docker image build,scripts: use non-experimental golang docker image Feb 28, 2024
@jchappelow
Copy link
Member Author

Well this seems just fine actually. Not just a test anymore. Initial download of the golang:1.22 builder can take a little time (10-20 second), but it's cached after that. Again, no affect on kwild image size.

@jchappelow jchappelow marked this pull request as draft February 28, 2024 18:15
@jchappelow
Copy link
Member Author

Back to draft as I'll include our custom postgres docker build/push in a new script with this PR.

@jchappelow jchappelow marked this pull request as ready for review February 28, 2024 21:24
Copy link
Contributor

@Yaiba Yaiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm;

@jchappelow jchappelow merged commit ec37209 into main Feb 29, 2024
1 check passed
@jchappelow jchappelow deleted the docker-updates branch February 29, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants