Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine: remove @action and @dataset env vars #409

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

jchappelow
Copy link
Member

@jchappelow jchappelow commented Dec 4, 2023

Resolves #405

This removes the @action and @dataset kuneiform environment variables from the execution engine.

Both ExecutionData fields are still used, so I just revised their docs.

Should happen next:

  • remove from Kuniform spec and parser
  • remove from docs

@jchappelow jchappelow added this to the v0.6.0 milestone Dec 4, 2023
@jchappelow
Copy link
Member Author

This one and #406 are going to have zero conflicts with #403 so I will actually merge them first. I'll wait on the other stuff that touches kwil-admin/rpc/go.mod/etc.

@jchappelow jchappelow merged commit 6d9180b into main Dec 5, 2023
2 checks passed
@jchappelow jchappelow deleted the fix-procedure-action-var branch December 5, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: @action modifier not inserting any data
2 participants