Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable cors Access-Control-Allow-Credentials #384

Merged
merged 1 commit into from
Nov 8, 2023
Merged

feat: enable cors Access-Control-Allow-Credentials #384

merged 1 commit into from
Nov 8, 2023

Conversation

Yaiba
Copy link
Contributor

@Yaiba Yaiba commented Nov 8, 2023 •
edited
Loading

For axios to working in frontend, our api need to set Access-Control-Allow-Credentials header

@Yaiba Yaiba requested a review from KwilLuke November 8, 2023 00:09
KwilLuke
KwilLuke approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@KwilLuke KwilLuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but we should probably do more research on these CORS configurations to make sure we aren't doing anything we shouldn't.

@brennanjl brennanjl merged commit 5ee9468 into main Nov 8, 2023
2 checks passed
@brennanjl brennanjl deleted the feature/enable-cors-allow-credentidal branch November 8, 2023 00:16
brennanjl pushed a commit that referenced this pull request Feb 26, 2024
@Yaiba @brennanjl
feat: enable cors Access-Control-Allow-Credentials (#384)
a64db0d
brennanjl pushed a commit that referenced this pull request Feb 26, 2024
@Yaiba @brennanjl
feat: enable cors Access-Control-Allow-Credentials (#384)
f0c36a9
jchappelow pushed a commit that referenced this pull request Feb 26, 2024
@Yaiba @jchappelow
feat: enable cors Access-Control-Allow-Credentials (#384)
4bf311f
brennanjl pushed a commit that referenced this pull request Feb 26, 2024
@Yaiba @brennanjl
feat: enable cors Access-Control-Allow-Credentials (#384)
0fea3e1
brennanjl pushed a commit that referenced this pull request Feb 26, 2024
@Yaiba @brennanjl
feat: enable cors Access-Control-Allow-Credentials (#384)
954c4b6
brennanjl pushed a commit that referenced this pull request Feb 26, 2024
@Yaiba @brennanjl
feat: enable cors Access-Control-Allow-Credentials (#384)
d56f8ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KwilLuke KwilLuke KwilLuke approved these changes

@brennanjl brennanjl brennanjl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yaiba @brennanjl @KwilLuke