-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
load extensions during compile time using go build tags #350
Conversation
21bfcbe
to
c060fdb
Compare
f31bdfc
to
10f07f4
Compare
452b501
to
69fd3e0
Compare
69fd3e0
to
71e4c31
Compare
A few pieces of feedback:
a. have an The expectation right now is that a user would register by importing a file and registering it here. Having many files that implement the functionality that they need to navigate around is weird.
|
8dd0134
to
a2cc5ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, this is an incomplete and speculative review. I will return to it asap.
27afb6c
to
cc118a3
Compare
cc118a3
to
ed6d2bd
Compare
ed6d2bd
to
e3eefeb
Compare
18b52e6
to
2dddabf
Compare
2dddabf
to
77c0dee
Compare
* load extensions during compile time using go build tags * remove scalar values and Extension struct for local extensions
* load extensions during compile time using go build tags * remove scalar values and Extension struct for local extensions
* load extensions during compile time using go build tags * remove scalar values and Extension struct for local extensions
* load extensions during compile time using go build tags * remove scalar values and Extension struct for local extensions
* load extensions during compile time using go build tags * remove scalar values and Extension struct for local extensions
* load extensions during compile time using go build tags * remove scalar values and Extension struct for local extensions
With the changes in the PR, the action extensions can be loaded and baked into kwild during compile time.
We still support remote extensions, that users can create and deploy using docker.
Support for users to create extensions locally and register them to the extension registry.
Included maths extensions with build tag "ext_test", it's similar to the existing remote math extension. Updated the test scripts to create instances and execute methods on both local "maths" and remote "math" extensions.