Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/serialize: fix decode error omitting code #346

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

jchappelow
Copy link
Member

@jchappelow jchappelow commented Oct 9, 2023

The decode errors when an unrecognized encoding type was detected were supposed to include the erroneous encoding type, not the entire serialized data. The errors now do what Encode does and print the type, not the data.

We saw this from Fractal:

panic while building kwild: failed to open engine: invalid encoding type: [4 140 36 41 67 226 173 26 124 254 85 200 86 86 194 142 1 118 201 171 56 196 160 181 175 240 33 172 173 53 116 38 81 83 103 6 192 230 115 39 95 184 92 187 252 211 119 178 10 101 69 179 104 108 102 240 221 240 203 49 238 228 216 109 244]

Copy link
Contributor

@Yaiba Yaiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brennanjl brennanjl merged commit 990bd48 into main Oct 10, 2023
2 checks passed
@brennanjl brennanjl deleted the enctype-err branch October 10, 2023 15:00
@jchappelow jchappelow added this to the v0.6.0 milestone Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants