add --nonce override flag to kwil-cli database commands

[jchappelow]

kwil-cli,pkg/client: add --nonce override flag to database cmds
This adds the ability to set a nonce when making a transaction.

Rather than giving every method a nonce input arg, I've added a
WithNonceFunc option to pkg/client.Client. This is perhaps a
little strange but the cascade from a new argument was rather
large, and it seemed a little out of place as the other arguments
pertain to the action rather than the transaction containing it.
Can be switched if we'd prefer.

See my review for notes about the pkg/client change. Very happy to change it.

[jchappelow]

DialClient is the one-shot client request helper. If the RoundTripper func wants to make multiple transactions this would have to change (or let it be auto).

[brennanjl]

Hmmm this feels wrong to me.

I think a more logical approach would be to add some sort of option to the commands that might require a nonce (e.g., client.ExecuteAction). This seems more logical, as it doesn't require the pkg/client consumer to reinstantiate a client for each transaction if they want fine-grained control over their nonces. Also, not every method on Client uses nonces; if somebody is simply reading data, it seems weird to concern them with a nonce

[jchappelow]

I think a more logical approach would be to add some sort of option to the commands that might require a nonce (e.g., client.ExecuteAction).

Yup, I actually completely agree with that. Had started that way but the already-variadic ExecuteAction actually sent me in a direction with no method signature changes. It out to be not bad. Changes made.

This seems more logical, as it doesn't require the pkg/client consumer to reinstantiate a client for each transaction if they want fine-grained control over their nonces

Definitely switching this up, but it was really up to the nonceFunc implementation, which can be defined to return different value each time (imagine a simple counter, or the it's a closure bound to a variable that the consumer mutates between requests, or more complex logic like doing some other RPCs before returning a value, etc.). Not needed and confusing though. Modifying the method signatures instead.

[Yaiba]

LGTM

[jchappelow]

@charithabandi Was this working OK for you? I thought you said you used the --nonce flag to test this morning but wasn't sure. Shall we get this one in before our two abci PRs?

[brennanjl]

Hmmm this feels wrong to me.

I think a more logical approach would be to add some sort of option to the commands that might require a nonce (e.g., client.ExecuteAction). This seems more logical, as it doesn't require the pkg/client consumer to reinstantiate a client for each transaction if they want fine-grained control over their nonces. Also, not every method on Client uses nonces; if somebody is simply reading data, it seems weird to concern them with a nonce

[jchappelow]

Went to the more sensible approach. We don't need a wacky way to patch in programmable nonce logic like that. Will retest later tonight to make sure it still works though.

[charithabandi]

@charithabandi Was this working OK for you? I thought you said you used the --nonce flag to test this morning but wasn't sure. Shall we get this one in before our two abci PRs?

Yup, tested it out again, it works for me.