[TEST] update to cometbft 0.38 #310
Conversation
consider going back to filepv, maintained
| @@ -122,7 +122,21 @@ func (v *ValidatorSigner) SignVote(chainID string, vote *tendermintTypes.Vote) e | |||
|
|
|||
| signBytes := types.VoteSignBytes(chainID, vote) | |||
|
|
|||
| // VoteExtensionSignBytes??? | |||
There was a problem hiding this comment.
Yeah, this had to be added. We might want to go back to their FilePV because it'll be always right and maintained. There's a ton of stuff changed in just this borrowed code in the last 10 months that this vote extension feature has been in the works.
Took a couple hours to identify the issue and it'll probably happen again in the future.
There was a problem hiding this comment.
Umm, in abci++, the application also controls the votes. some work might be needed to support that
There was a problem hiding this comment.
It can control votes, but the app can decide to require vote extensions or not. The simple update approach is to return an empty byte slice in ExtendVote and requiring en empty slice in VerifyVoteExtension
There was a problem hiding this comment.
Background: cometbft/cometbft#1001
Our signer has to generate extension signatures. This update in this PR supports that.
|
Can reopen when we're ready to update. Probably when there's a 0.38.1 or greater patch release. |
DO NOT MERGE. For evaluation.
This is working as expected. Several updates:
BeginBlock, allDeliverTxandEndBlockinto oneFinalizeBlockFinalizeBlock, previously returned byCommit. Fortunately it was OK to move some code from commit up to finalize.abci/type.Applicationinterface:error(yay reason)Nodeis now given a "connection-synchronized" client instead of the previous one that has a mutex for all the "connections"pkg/abci/cometbft/privval/privvalidator.goto deal with the new "vote extension". We might want to switch back to the supportedFilePVtype using an ephemoral key file, or PR a type that uses a key from memory.BroadcastTxCommitchanged a field name (hurray unstable APIs)Builds but there's something funny with the new vote extensions and the signer.
Signer needed updating.panic: non-recoverable error when signing vote (30243/0): extensions must be present IFF vote is a non-nil Precommit; present false, vote type 2, is nil false