[discussion] make procedure instruction execution from view/Call RO #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brennanjl
force-pushed
the
fix/execution-view-call-ro
branch
from
ff1f853
to
0adc7d3
Compare
brennanjl
approved these changes
Sep 14, 2023
This was referenced Sep 14, 2023
Closed
brennanjl
added a commit
that referenced
this pull request
Sep 14, 2023
…298) * add a mutex to SqliteClient for write concurrency control * make abci Commit guarantee state is committed * hotfix for concurrent read-schema issue * execution: commitedOnly on read-only sqlite conn --------- Co-authored-by: brennan lamey <[email protected]>
brennanjl
added a commit
that referenced
this pull request
Feb 26, 2024
…298) * add a mutex to SqliteClient for write concurrency control * make abci Commit guarantee state is committed * hotfix for concurrent read-schema issue * execution: commitedOnly on read-only sqlite conn --------- Co-authored-by: brennan lamey <[email protected]>
brennanjl
added a commit
that referenced
this pull request
Feb 26, 2024
…298) * add a mutex to SqliteClient for write concurrency control * make abci Commit guarantee state is committed * hotfix for concurrent read-schema issue * execution: commitedOnly on read-only sqlite conn --------- Co-authored-by: brennan lamey <[email protected]>
jchappelow
added a commit
that referenced
this pull request
Feb 26, 2024
…298) * add a mutex to SqliteClient for write concurrency control * make abci Commit guarantee state is committed * hotfix for concurrent read-schema issue * execution: commitedOnly on read-only sqlite conn --------- Co-authored-by: brennan lamey <[email protected]>
brennanjl
added a commit
that referenced
this pull request
Feb 26, 2024
…298) * add a mutex to SqliteClient for write concurrency control * make abci Commit guarantee state is committed * hotfix for concurrent read-schema issue * execution: commitedOnly on read-only sqlite conn --------- Co-authored-by: brennan lamey <[email protected]>
brennanjl
added a commit
that referenced
this pull request
Feb 26, 2024
…298) * add a mutex to SqliteClient for write concurrency control * make abci Commit guarantee state is committed * hotfix for concurrent read-schema issue * execution: commitedOnly on read-only sqlite conn --------- Co-authored-by: brennan lamey <[email protected]>
brennanjl
added a commit
that referenced
this pull request
Feb 26, 2024
…298) * add a mutex to SqliteClient for write concurrency control * make abci Commit guarantee state is committed * hotfix for concurrent read-schema issue * execution: commitedOnly on read-only sqlite conn --------- Co-authored-by: brennan lamey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, just for discussion. This stacks a few fixes up (including @brennanjl's metadata cache fix) plus one commit toying with making execution via Call use a read-only sqlite connection: ff1f853