sqlite: test formatFilepath handling of paths w/wo trailing slash #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchappelow
changed the title
jchappelow
commented
Aug 28, 2023
| func (c *Connection) formatFilePath(fileName string) string { | ||
| return fmt.Sprintf("%s.sqlite", filepath.Join(c.path, fileName)) |
There was a problem hiding this comment.
@charithabandi yeah, you did have the fix, I must have seen a commit slightly earlier. I'm adding the tests in this PR that I was writing from earlier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug was fixed in https://github.com/kwilteam/kwil-db/pull/220/files#diff-dbaecd2f2532274edc2a7f21fd7ea499242a7cd1867303952f13bb54e8bfa8a1R87 so that the path used in sqlite connection did not have to assume a trailing slash.
I was looking into this with @charithabandi and I added a testable helper function to ensure this path construction always remains robust.