Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

various bug fixes #227

Merged
merged 3 commits into from
Aug 28, 2023
Merged

various bug fixes #227

merged 3 commits into from
Aug 28, 2023

Conversation

brennanjl
Copy link
Collaborator

This PR contains various bug fixes, including:

  • A bug where databases could not be used properly until the node was restarted
  • A bug where database schemas could not be returned
  • A bug where deployed databases would contain extra nil modifiers in their schema
  • A bug where the Kwil client would not generate DBIDs properly
  • A bug where GetSchema would return an "internal" error code incorrectly
  • A bug where deployed schemas did not necessarily use the wallet address of the deployer as the "owner"

jchappelow
jchappelow requested changes Aug 28, 2023
View reviewed changes
Copy link
Member

@jchappelow jchappelow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proto is rewinding the TxQuery addition. Probably just because this PR is in draft, but I wanted to call it out.

internal/controller/grpc/txsvc/v1/schema.go Outdated Show resolved Hide resolved
@Yaiba Yaiba added the bug Something isn't working label Aug 28, 2023
@brennanjl brennanjl marked this pull request as ready for review August 28, 2023 16:17
@brennanjl
Copy link
Collaborator Author

Changed the error checking, as well as got proto to the correct version

@Yaiba
Copy link
Contributor

Yaiba commented Aug 28, 2023

I'm not sure 'merge branch main' will break our linear history or not, but probably just stick to rebase ?

@brennanjl
Copy link
Collaborator Author

Oh, that's probably because I let github do it. I can go back and fix

@jchappelow jchappelow merged commit 65a4dc4 into main Aug 28, 2023
2 checks passed
@jchappelow jchappelow deleted the fix/database-deployment-bugs branch August 28, 2023 16:46
@jchappelow jchappelow added this to the v0.6.0 milestone Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchappelow jchappelow jchappelow approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@brennanjl @Yaiba @jchappelow