Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed serialization unit tests to actually check equality #217

Merged
merged 1 commit into from
Aug 24, 2023
Merged

fixed serialization unit tests to actually check equality #217

merged 1 commit into from
Aug 24, 2023

Conversation

brennanjl
Copy link
Collaborator

Fixed the issue in the serialization tests where it did not actually check if the result was equal to the desired input.

@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

jchappelow
jchappelow approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@jchappelow jchappelow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Solid use of generics, which is saying a lot coming from me. ;)

@jchappelow jchappelow merged commit 27df36e into main Aug 24, 2023
3 checks passed
@jchappelow jchappelow deleted the fix/serialize-tests branch August 24, 2023 13:31
@jchappelow jchappelow added this to the v0.6.0 milestone Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchappelow jchappelow jchappelow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@brennanjl @jchappelow