Fix/case sensitive mutability

[brennanjl]

Fixed a basic bug where incoming schemas can fail due to having the wrong mutability case

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[jchappelow]

I had noticed a MutabilityType enumeration:

kwil-db/pkg/transactions/payloads.go

Lines 160 to 163 in 6dbd808

	const (
	MutabilityUpdate MutabilityType = "update"
	MutabilityView MutabilityType = "view"
	)

Do those values or that type not apply here?

[brennanjl]

Yep, the client sends across a string though (gRPC doesn't restrict values that are not valid enums if they are of the correct underlying type), so we have to manually do the conversion. The bug was where this manual conversion occurs.

[jchappelow]

I see, gRPC would unmarshal even invalid values.

I guess my question is, what had you planned for MutabilityType? It's enumerated values are unused except in a recently added test, which is why I assumed you intended to use it somewhere around here or in one of the conversion helpers.

kwil-db/pkg/transactions/payloads_test.go

Lines 60 to 64 in a3c253e

	Actions: []*transactions.Action{
	{
	Name: "get_user",
	Inputs: []string{"user_id"},
	Mutability: transactions.MutabilityUpdate.String(),

I got here because I went looking for const declarations of the "UPDATE" and "VIEW" strings used in the switch (good practice instead of string literals) and I all I found was the enum.

[brennanjl]

Hmm, I think that must've been something that was lost in translation. Looking at it more, it does not seem like we need it.

[brennanjl]

In the engine package, I use enums a lot. pkg/engine/types contains all sorts of enums. The concept of "mutability" doesn't quite translate 1-1 there; the engine treats everything as mutable, and treats immutability as a special case right now. There isn't a great reason for this, other than that it was the easiest way to implement that feature in the engine.