Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abci: use a semaphore for commit/apply/beginblock #196

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Commits on Aug 22, 2023

  1. abci: use a semaphore for commit/apply/beginblock

    Consensus method requests from cometbft are synchronous, but a portion
    of the work of Commit is launched in a goroutine, so we block a
    subsequent BeginBlock from starting new changes. We do this by
    acquiring a semaphore with max concurrency of 1 at the start of
    BeginBlock, and releasing it when the changes from Commit have finished
    applying. A mutex is rarely held for longer than the duration of a
    local function, while a waitgroup does not provide atomic Wait/Add
    semantics that fit here.
    jchappelow committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    083bfdb View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Configuration menu
    Copy the full SHA
    8cb890d View commit details
    Browse the repository at this point in the history