add linter action and task, fix append bug in sql/client #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchappelow
commented
Aug 17, 2023
Comment on lines
-196
to
198
| pks := make([][]byte, len(primaryKeys)) | ||
| pks := make([][]byte, 0, len(primaryKeys)) | ||
| for _, primaryKey := range primaryKeys { | ||
| pks = append(pks, primaryKey.Blob()) |
There was a problem hiding this comment.
The makezero linter that I've enabled in CI found this bug.
Yaiba
reviewed
Aug 17, 2023
Yaiba
reviewed
Aug 17, 2023
.github/workflows/ci.yaml
Outdated
| @@ -48,6 +48,13 @@ jobs: | |||
| run: | | |||
| task pb:compile:v1 | |||
|
|
|||
| - name: golangci-lint | |||
There was a problem hiding this comment.
Will this step change the code?
There was a problem hiding this comment.
No, linters only report issues, but don't change anything.
The new task fmt will change it however, but that's not in CI.
Thx. Just testing something else right now, pls don't merge yet |
build all before lint to speed up lint and test compile
|
Kudos, SonarCloud Quality Gate passed!
|
|
OK guys, good to go. Some things to note:
We should set up our IDEs to lint on save and/or run |
Yaiba
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.