Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/act test env setup #183

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Refactor/act test env setup #183

merged 1 commit into from
Aug 14, 2023

Conversation

Yaiba
Copy link
Contributor

@Yaiba Yaiba commented Aug 14, 2023

This pr makes acceptance/integration test basically "run" in the new test environment, the new test env:

  • generate temporay configuration based on test requirement
  • hardcoded docker-compose for basic configuration, new config(for kwild) could be added by change envs
  • run required nodes in docker
  • should be enough for us to spin up a dev environment. It will panic when boot up kwild rn, so you need to adjust the boot process to make kwild actually run

@Yaiba Yaiba requested a review from brennanjl August 14, 2023 18:20
@Yaiba Yaiba marked this pull request as ready for review August 14, 2023 18:20
@Yaiba Yaiba force-pushed the refactor/act-test branch 2 times, most recently from ded329e to 7495602 Compare August 14, 2023 18:33
@sonarcloud
Copy link

sonarcloud bot commented Aug 14, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 3 Code Smells

No Coverage information No Coverage information
2.9% 2.9% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link
Collaborator

@brennanjl brennanjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this

@brennanjl brennanjl merged commit d2d19d3 into main Aug 14, 2023
0 of 3 checks passed
@brennanjl brennanjl deleted the refactor/act-test branch August 14, 2023 18:40
brennanjl added a commit that referenced this pull request Aug 14, 2023
@jchappelow
Copy link
Member

  • It will panic when boot up kwild rn, so you need to adjust the boot process to make kwild actually run

You mentioned this at the meeting, but I don't follow. What adjustments to make and where? Thanks!

Actually, perhaps tomorrow I can sit down with you for 15-20 minutes to get a little intro to the test environments? I haven't had a lot of chance to do so since I started on IDOS and then jumped into kwild just as everything was being refactored. :)

@Yaiba
Copy link
Contributor Author

Yaiba commented Aug 15, 2023

  • It will panic when boot up kwild rn, so you need to adjust the boot process to make kwild actually run

You mentioned this at the meeting, but I don't follow. What adjustments to make and where? Thanks!

Actually, perhaps tomorrow I can sit down with you for 15-20 minutes to get a little intro to the test environments? I haven't had a lot of chance to do so since I started on IDOS and then jumped into kwild just as everything was being refactored. :)

The current test env stilll runs in Docker, but in a different fashion. But the basic setup has complete, it configures whatever Kwild need to just run gRPC server etc. You should be able to spin up a local instance of everything by run task dev:up, if Kwild actually runs(with all components correctly wired).
So the purpose is with this test environement, we can slowly assemble all the components we need.

Before merge @brennanjl new-transaction structure, kwild will just panic on NoImplementation since the ABCI app is not fully wired with different components, that's the adjustments i mentioned.
After the merge it still panic on NoImplementation but this time it panics on PrivateKey interface. I guess the adjustments becomes to:

  • first, avoid load PrivateKey for test setup and Kwild
  • second, make Kwild actually run

Actually i think i can make a quick pr to make test setup avoid load PrivateKey, so everyone could just focus on making Kwild run.

Yeah i can walk you through the test environment tomorrow, could use some feedback.

@jchappelow jchappelow added this to the v0.6.0 milestone Sep 28, 2023
brennanjl pushed a commit that referenced this pull request Feb 26, 2024
brennanjl pushed a commit that referenced this pull request Feb 26, 2024
jchappelow pushed a commit that referenced this pull request Feb 26, 2024
brennanjl pushed a commit that referenced this pull request Feb 26, 2024
brennanjl pushed a commit that referenced this pull request Feb 26, 2024
brennanjl pushed a commit that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants