Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comet rebase followup, allow to build and test most things #169

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Conversation

jchappelow
Copy link
Member

@jchappelow jchappelow commented Aug 9, 2023

This just lets us do go build ./... on the repo.

The stuff in the old cli app is mostly pointless, other than to avoid build errors. It's clearly broken. (kwild build with non-modulized KwilDbApplication, but it will not work; just crash -- we'll focus on porting to the new pkg/abci.AbciApp

I've finished the purge of internal/entity, and commented out most of the eth chain/token/approve/etc. bits that, but it doesn't magically fix the acceptance tests, although they at least compile.

The validator work I'm doing is on top of this so that my workspace isn't borken.

Is this what we want?

@jchappelow
Copy link
Member Author

Dang, I already have to sync main. Hang on.

@Yaiba
Copy link
Contributor

Yaiba commented Aug 9, 2023

does kwild build after this?

@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
1.3% 1.3% Duplication

@jchappelow
Copy link
Member Author

Just rebased and force pushed. If anyone had it checked out, do a git fetch and then a git reset --hard origin/justbuild

@jchappelow
Copy link
Member Author

jchappelow commented Aug 9, 2023

does kwild build after this?

Yes, it builds. It's is just going to crash for now, but everything compiles.

We can get it fixed in the old KwilDbApplication in internal/_abci-apps/kwild.go, but we should not bother, instead directing our efforts on adapting into the new modules framework.

Copy link
Contributor

@Yaiba Yaiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yaiba Yaiba merged commit 8c9ea0e into main Aug 9, 2023
1 of 3 checks passed
@Yaiba Yaiba deleted the justbuild branch August 9, 2023 20:17
@jchappelow jchappelow added this to the v0.6.0 milestone Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants