admin: use specified private key with setup init #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchappelow
force-pushed
the
setup-init-priv-key
branch
2 times, most recently
from
bbab678
to
6efa77c
Compare
|
Not urgent @brennanjl, but I wanted to ensure this behavior isn't out of line with your intent for this command, particularly since you recently updated it. I think this is a minor change and should not cause any problems, but it does help some workflows where you want to initialize your node's root directory with an existing private key and existing genesis.json. |
jchappelow
force-pushed
the
setup-init-priv-key
branch
2 times, most recently
from
817f2d9
to
8860116
Compare
jchappelow
force-pushed
the
setup-init-priv-key
branch
from
8860116
to
4493787
Compare
|
@charithabandi Would you please re-approve? I added docs and de-duped some other instances of copyfile |
brennanjl
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires and based on #1059
Resolves #1057
This change alters how
setup inithandles the--app.private_key_pathflag.Recently it was modified to ignore the flag entirely, with the apparent intent of ensuring the generated
config.tomlin the initialized root directory would always beprivate_key_path = "private_key"with the actual private key always being written into the root directory. This behavior is good, however, when the flag is set it is desirable to import the private key file pointed to by this flag, which is what this change does.This new behavior streamlines the production deployment guide where the workflow for the genesis validator set involves preparing the private keys so that then can be used in the genesis file created with
kwil-admin setup genesisfirst.