test: randomized non-overlapping networks on 10.A.B.0/20 #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchappelow
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
jchappelow
force-pushed
the
docker-network-rand
branch
from
69ae505
to
d8bffa4
Compare
jchappelow
changed the title
jchappelow
force-pushed
the
docker-network-rand
branch
from
d8bffa4
to
9076747
Compare
jchappelow
changed the title
|
Closing but not deleting branch in case we want to resurrect this. |
|
I think we should at least try this before entirely reverting the ipam section of docker network config. I'm seeing frequent docker errors in CI related to overlapping networks. Usually it's just following a failed test that is not cleaned up, but it is misleading when trying to diagnose CI failure. |
charithabandi
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we cannot set Docker's
default-address-poolsin daemon.json on Github Actions like we did our our old self-hosted running, this PR attempts to pick random /20 networks in 10.A.B.0/20 (there are 4096 subnets each with 4096 addresses) rather than use "10.9.0.0/16", which can cause trouble if the network isn't taken down fast enough or if a test fails and decides not to clean up the network, which can break subsequent tests without different networks.