Skip to content

Commit

Permalink
made gavins requested changes
Browse files Browse the repository at this point in the history
  • Loading branch information
brennanjl committed Oct 6, 2023
1 parent ccab254 commit 615cc31
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 6 deletions.
2 changes: 1 addition & 1 deletion extensions/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Extensions are compile-time loaded pieces of code that impact core `kwild` funct

## Interfaces and Drivers

Extensions can made by implementing a driver for one of many interfaces. These implementations should be registered using Go's `init()` function, which will register the driver when the package is loaded. This is conceptually similar to Go's `database/sql` package, where users can implement custom `database/sql/driver/Driver` implementations.
Extensions can be made by implementing a driver for one of many interfaces. These implementations should be registered using Go's `init()` function, which will register the driver when the package is loaded. This is conceptually similar to Go's `database/sql` package, where users can implement custom `database/sql/driver/Driver` implementations.

## Build Tags

Expand Down
1 change: 1 addition & 0 deletions pkg/auth/ed25519.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ func init() {
// ed25519 constants
const (
// using Ed25519Auth for the authenticator name
Ed25519Auth = "ed25519"

// ed25519SignatureLength is the expected length of a signature
ed25519SignatureLength = 64
Expand Down
1 change: 1 addition & 0 deletions pkg/auth/eth_personal_sign.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ func init() {

const (
// using EthPersonalSignAuth for the authenticator name
EthPersonalSignAuth = "secp256k1_ep"

// ethPersonalSignSignatureLength is the expected length of a signature
ethPersonalSignSignatureLength = 65
Expand Down
5 changes: 0 additions & 5 deletions pkg/auth/signer.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,6 @@ import (
"github.com/kwilteam/kwil-db/pkg/crypto"
)

const (
EthPersonalSignAuth = "secp256k1_ep"
Ed25519Auth = "ed25519"
)

// Signature is a signature with a designated AuthType, which should
// be used to determine how to verify the signature.
// It seems a bit weird to have a field "Signature" inside a struct called "Signature",
Expand Down

0 comments on commit 615cc31

Please sign in to comment.