Skip to content

Commit

Permalink
CI,docs: remove protoc install and requirement (#994)
Browse files Browse the repository at this point in the history
* CI,docs: remove protoc install and requirement

* another protobuf mention
  • Loading branch information
jchappelow authored Sep 18, 2024
1 parent e692273 commit 5e91c02
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 19 deletions.
5 changes: 0 additions & 5 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,6 @@ jobs:
with:
submodules: true

- name: Install Protoc
uses: arduino/setup-protoc@v3
with:
version: '23.4'

- name: Install Taskfile
uses: arduino/setup-task@v2

Expand Down
6 changes: 0 additions & 6 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,6 @@ jobs:
submodules: true
token: ${{ secrets.KWIL_MACH_SECRET }}

- name: Install Protoc
uses: arduino/setup-protoc@v2
with:
version: '23.4'
repo-token: ${{ secrets.KWIL_MACH_SECRET }}

- name: Install Taskfile
uses: arduino/setup-task@v1
with:
Expand Down
4 changes: 1 addition & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,7 @@ For more information on kwil-db, check out the [Kwil node documentation](https:/
To build Kwil, you will need to install:

1. [Go](https://golang.org/doc/install) 1.22 or 1.23
2. (optional) [Protocol Buffers](https://protobuf.dev/downloads/), with the `protoc` executable binary on your `PATH`.
3. (optional) [Taskfile](https://taskfile.dev/installation)
4. (optional) Protocol buffers go plugins and other command line tools. The `tool` task will install the required versions of the tools into your `GOPATH`, so be sure to include `GOPATH/bin` on your `PATH`.
2. (optional) [Taskfile](https://taskfile.dev/installation)

```shell
task tools
Expand Down
4 changes: 2 additions & 2 deletions Taskfile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ tasks:
fmt:
desc: Format the code
cmds:
# goimports does not allow to ignore certain paths (protobuf) with modules,
# so we have to list all the folders that are adjacent to protobuf.
# goimports does not allow to ignore certain paths with modules,
# so we have to list all the folders that are adjacent generated code.
- |
goimports -format-only -w ./cmd ./common ./internal ./test ./testing \
./core ./extensions ./parse/*.go ./parse/wasm ./parse/postgres
Expand Down
4 changes: 1 addition & 3 deletions core/types/admin/types.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
// Package types contains the type used by the administrative RPC client and
// servers. These types are shared like the protobuf types that these mimick,
// but they contain the json tags and marshalling behavior we want, plus they
// are not burdened by fields and methods from the google protobuf packages.
// servers.
package types

import (
Expand Down

0 comments on commit 5e91c02

Please sign in to comment.