Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two small fixes #35

Merged
merged 2 commits into from
May 30, 2021
Merged

Two small fixes #35

merged 2 commits into from
May 30, 2021

Conversation

taralx
Copy link
Contributor

@taralx taralx commented May 30, 2021

  1. Add missing yarn devDependency
    This means that npm install actually installs everything required to e.g. run tests.
  2. Make all handle calls await
    Without this, throws in handle cause an annoying "unhandled exception" abort with no stack trace.

@kwhitley kwhitley self-requested a review May 30, 2021 05:22
Copy link
Owner

@kwhitley kwhitley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍

@kwhitley
Copy link
Owner

Thanks @taralx! I started a review to suggest replacing references to yarn with npm run in the package.json scripts (instead of adding yarn as a dev dep), but given that I explicitly (for now at least) want a consistent yarn.lock, I think your solution is better.

Re. the async - I was just lazy ;) I called async on the ones that explicitly needed it to resolve the tests and cut corners on the rest obviously. Thanks for the cleanup!! 🙏

@kwhitley kwhitley merged commit 64c6e35 into kwhitley:v2.x May 30, 2021
@taralx taralx deleted the patch-1 branch May 30, 2021 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants