Bugfix/ts expect error is a bug #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this case the 'as' is asserting "I know better than the compiler" and it is both true and more accurate than saying "I expect typescript to error out here." As an added benefit, `as` does more type checking than 'expect error', so you get just a small bit more type safety.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a few type places where you opt out of TS with 'expect-error' in the flow branch. Most are just instances of missing
extendsthat you actually already had elsewhere. One is using anasinstead of ants-expect-error.The problem with the expect-error is that if you miss something else you could introduce bugs since it is line level ignoring. By using an
asyou assert to the compiler it's getting something wrong, but in exchange the compiler trusts you and continues checking everything else that it can.Related Issue
Link to the related issue: None
Type of Change (select one and follow subtasks)