Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add types path to package.json exports #114

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Conversation

jeevcat
Copy link
Contributor

@jeevcat jeevcat commented Jul 15, 2022

In a ESM project using TypeScript, I am unable to import types correctly.

I have followed the suggestions recommended here, which have resolved the issue: https://stackoverflow.com/questions/72457791/typescript-packages-that-ship-with-mjs-and-d-ts-but-without-d-mts-how-to-i

@ConnorBaker
Copy link

I can second that this change fixed importing types for me (using VS Code with the Typescript extension).

@kwhitley kwhitley merged commit 4fd3427 into kwhitley:v2.x Jul 18, 2022
@kwhitley
Copy link
Owner

Thanks for the fix @jeevcat (and @ConnorBaker for the confirmation)!! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants