fix cloud run new api change for annotations

kwadie · Feb 23, 2023 · 52a26ba · 52a26ba
1 parent 6f2370b
commit 52a26ba
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/terraform/modules/bigquery/main.tf b/terraform/modules/bigquery/main.tf
@@ -37,7 +37,8 @@ resource "google_bigquery_table" "logging_table" {
 
   deletion_protection = true
 
-  labels = var.common_labels
+  # TODO: labels causes Terraform to force replace the table at each deployment for some reason which we don't want to do for the log table containing history logs
+  # labels = var.common_labels
 }
 
 

diff --git a/terraform/modules/cloud-run/main.tf b/terraform/modules/cloud-run/main.tf
@@ -42,15 +42,19 @@ resource "google_cloud_run_service" "service" {
         }
       }
     }
-
     metadata {
       annotations = {
         "autoscaling.knative.dev/maxScale"  = var.max_containers
-        "run.googleapis.com/ingress" : "internal"
+        #"run.googleapis.com/ingress" : "internal"
       }
-      labels = var.common_labels
     }
+  }
 
+  metadata {
+    annotations = {
+      "run.googleapis.com/ingress" : "internal"
+    }
+    labels = var.common_labels
   }
 
   traffic {