Skip to content

Commit

Permalink
roachtest: output error and bump vmodule on lease preferences test
Browse files Browse the repository at this point in the history
The `lease-preferences` roachtest did not log the state of preference
conformance on timeout. This commit updates the error check, hit on
timeout, to show the result.

Also bump the vmodule settings to show lease acquisitions and lease
preference errors.

Epic: none
Informs: cockroachdb#107862

Release note: None
  • Loading branch information
kvoli committed Jul 31, 2023
1 parent e57e974 commit b11af97
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions pkg/cmd/roachtest/tests/lease_preferences.go
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,8 @@ func runLeasePreferences(
// dc=2: n3 n4
// ...
// dc=N: n2N-1 n2N
fmt.Sprintf("--locality=region=fake-region,zone=fake-zone,dc=%d", (node-1)/2+1))
fmt.Sprintf("--locality=region=fake-region,zone=fake-zone,dc=%d", (node-1)/2+1),
"--vmodule=replica_proposal=2,replicate_queue=3,replicate=3")
c.Start(ctx, t.L(), opts, settings, c.Node(node))

}
Expand Down Expand Up @@ -223,7 +224,7 @@ func runLeasePreferences(
checkLeasePreferenceConformance := func(ctx context.Context) {
result, err := waitForLeasePreferences(
ctx, t, c, spec.checkNodes, spec.waitForLessPreferred, stableDuration)
require.NoError(t, err)
require.NoError(t, err, result)
require.Truef(t, !result.violating(), "violating lease preferences %s", result)
if spec.waitForLessPreferred {
require.Truef(t, !result.lessPreferred(), "less preferred preferences %s", result)
Expand Down

0 comments on commit b11af97

Please sign in to comment.