Skip to content

Commit

Permalink
split: convert example tests into datadriven
Browse files Browse the repository at this point in the history
There were existing example tests for evaluating the load based splitter. These
were not a part of testing but instead could be run ad-hoc for
experiments. This commit updates these tests to be datadriven in order
to spot regressions easily in the load based splitter. The datadriven
interface may also be used for experimental evaluation in an ad-hoc
manner, similar to before.

Release note: None
  • Loading branch information
kvoli committed Apr 27, 2023
1 parent c2ceeb7 commit 23a1856
Show file tree
Hide file tree
Showing 5 changed files with 906 additions and 202 deletions.
4 changes: 4 additions & 0 deletions pkg/kv/kvserver/split/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -31,16 +31,20 @@ go_test(
"weighted_finder_test.go",
],
args = ["-test.timeout=55s"],
data = glob(["testdata/**"]),
embed = [":split"],
deps = [
"//pkg/keys",
"//pkg/roachpb",
"//pkg/testutils/datapathutils",
"//pkg/testutils/skip",
"//pkg/util/encoding",
"//pkg/util/leaktest",
"//pkg/util/metric",
"//pkg/util/stop",
"//pkg/util/timeutil",
"//pkg/workload/ycsb",
"@com_github_cockroachdb_datadriven//:datadriven",
"@com_github_stretchr_testify//assert",
"@com_github_stretchr_testify//require",
"@org_golang_x_exp//rand",
Expand Down
Loading

0 comments on commit 23a1856

Please sign in to comment.