test_runner: do not report an error when tests are passing

PR-URL: nodejs#43919 Reviewed-By: Mestery <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
kvakil · Jul 21, 2022 · 2fd4c01 · 2fd4c01
1 parent 81fe9a3
commit 2fd4c01
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/internal/main/test_runner.js b/lib/internal/main/test_runner.js
@@ -114,7 +114,7 @@ function runTestFile(path) {
       err = error;
     });
 
-    const { 0: { code, signal }, 1: stdout, 2: stderr } = await SafePromiseAll([
+    const { 0: { 0: code, 1: signal }, 1: stdout, 2: stderr } = await SafePromiseAll([
       once(child, 'exit', { signal: t.signal }),
       child.stdout.toArray({ signal: t.signal }),
       child.stderr.toArray({ signal: t.signal }),

diff --git a/test/parallel/test-runner-exit-code.js b/test/parallel/test-runner-exit-code.js
@@ -1,5 +1,6 @@
 'use strict';
 const common = require('../common');
+const fixtures = require('../common/fixtures');
 const assert = require('assert');
 const { spawnSync } = require('child_process');
 const { setTimeout } = require('timers/promises');
@@ -28,6 +29,10 @@ if (process.argv[2] === 'child') {
   assert.strictEqual(child.status, 0);
   assert.strictEqual(child.signal, null);
 
+  child = spawnSync(process.execPath, ['--test', fixtures.path('test-runner', 'subdir', 'subdir_test.js')]);
+  assert.strictEqual(child.status, 0);
+  assert.strictEqual(child.signal, null);
+
   child = spawnSync(process.execPath, [__filename, 'child', 'fail']);
   assert.strictEqual(child.status, 1);
   assert.strictEqual(child.signal, null);