-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reapply current JWT before executing offlineQueue requests #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-88
to
-90
strategy: | ||
matrix: | ||
node-version: ["16", "18"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is useless since the version used to test the snippets is the version set in the docker compose file above
fmauNeko
approved these changes
May 17, 2024
alexandrebouthinon
force-pushed
the
KZLPRD-310/fix-jwt-in-offline-queue
branch
from
May 17, 2024 09:33
ae6f3a3
to
72709cb
Compare
alexandrebouthinon
force-pushed
the
KZLPRD-310/fix-jwt-in-offline-queue
branch
from
May 17, 2024 09:44
72709cb
to
771b70a
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Jun 3, 2024
## [7.11.3](v7.11.2...v7.11.3) (2024-06-03) ### Bug Fixes * Reapply current JWT before executing offlineQueue requests ([#744](#744)) ([ea1872a](ea1872a))
🎉 This PR is included in version 7.11.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Reapply current JWT before executing offlineQueue requests.
Since the final user could use the authenticator with a short JWT TTL or being disconnected for a big amount of time from his Kuzzle backend.