Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] notifier cache and storage set to undefined #1316

Merged
merged 2 commits into from
Jun 6, 2019

Conversation

benoitvidis
Copy link
Contributor

What does this PR do ?

Fix notifier issue introduced by #1311
Kuzzle notifier is instanciated before the services are and notifier.cache and storage properties were set to undefined.

How should this be manually tested?

bash features/run.sh

@codecov
Copy link

codecov bot commented Jun 6, 2019

Codecov Report

Merging #1316 into 1-dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           1-dev   #1316   +/-   ##
=====================================
  Coverage   93.8%   93.8%           
=====================================
  Files         98      98           
  Lines       6991    6991           
=====================================
  Hits        6558    6558           
  Misses       433     433
Impacted Files Coverage Δ
lib/api/core/notifier.js 72.93% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea9205d...5a8478c. Read the comment docs.

Copy link
Contributor

@scottinet scottinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did run the functional tests, and then I made a few cosmetic changes and I didn't bother re-running the tests... Sorry. 😑

@scottinet scottinet merged commit 0a5774f into 1-dev Jun 6, 2019
@scottinet scottinet deleted the hotfix-functional-tests branch June 6, 2019 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants