Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(SMTP): Make it possible to choose between TLS, StartTLS et insecure SMTP connection #20

Merged
merged 5 commits into from
Dec 19, 2023

Conversation

alexandrebouthinon
Copy link
Member

What does this PR do ?

Add the feature allowing developer to choose between insecure, TLS or StartTLS connection where instantiating a new SMTP client from the Hermes Plugin

hermesMessengerPlugin.clients.smtp.addAccount(
  "common",
  "smtp.example.com",
  587,
  "dummyUser",
  "dummyPass",
  "[email protected]",
  SMTPClientSSLMode.NONE
);

hermesMessengerPlugin.clients.smtp.addAccount(
  "starttls",
  "smtp.example.com",
  587,
  "dummyUser",
  "dummyPass",
  "[email protected]",
  SMTPClientSSLMode.STARTTLS
);

hermesMessengerPlugin.clients.smtp.addAccount(
  "tls",
  "smtp.example.com",
  465,
  "dummyUser",
  "dummyPass",
  "[email protected]",
  SMTPClientSSLMode.TLS
);

@alexandrebouthinon alexandrebouthinon force-pushed the fix/KZLPRD-195-SSL-config branch 2 times, most recently from 4124587 to ab977ec Compare December 15, 2023 13:38
@alexandrebouthinon alexandrebouthinon merged commit 67f8e7e into develop Dec 19, 2023
2 checks passed
@alexandrebouthinon alexandrebouthinon deleted the fix/KZLPRD-195-SSL-config branch December 19, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants