Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: stop using measures from assets and devices in exporter #369

Open
wants to merge 1 commit into
base: 2-dev
Choose a base branch
from

Conversation

Kuruyia
Copy link
Contributor

@Kuruyia Kuruyia commented Sep 2, 2024

What does this PR do ?

This modifies the digital twin exporter to use the recently introduced ask:device-manager:${type}:get-last-measures ask to retrieve the measures of a digital twin, instead of relying on the measures embedded in their documents.

This is in preparation for the removal of the measures and lastMeasuredAt fields in the documents of the assets and devices collections.

Other changes

A new mechanism has been introduced in the abstract exporter, the export stream augmenters, that are used to modify the exporter search results right before they get written to the export stream.

Digital twin exporter tests were also updated to check the exact values of the export results, and to sort the export client-side (because sorting by measure in the request is no longer supported).

Breaking changes

This deprecates the use of the measures and lastMeasuredAt fields in the query and sort parameters of the export request.

In the IoT Platform, the following places were identified that will be affected by this deprecation:

  • Devices.vue: the device export request allows filtering by measure type, which will no longer be possible.
  • OrphanDeviceList.vue: the device export request allows filtering by measure type, which will no longer be possible.

Part of KZLPRD-438.

@Kuruyia Kuruyia changed the title feat!: stop using measures in assets and devices in exporter feat!: stop using measures from assets and devices in exporter Sep 3, 2024
@etrousset etrousset added the 3.0 label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants