Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the API synchronous #44

Merged
merged 3 commits into from
May 27, 2021
Merged

Make the API synchronous #44

merged 3 commits into from
May 27, 2021

Conversation

scottinet
Copy link
Contributor

⚠️ depends on #43

Description

Remove all promises from the Koncorde's API

@scottinet scottinet self-assigned this May 25, 2021
@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #44 (e8a765b) into 4-dev (267a120) will increase coverage by 0.28%.
The diff coverage is 97.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##            4-dev      #44      +/-   ##
==========================================
+ Coverage   96.63%   96.91%   +0.28%     
==========================================
  Files          33       33              
  Lines        1009     1004       -5     
==========================================
- Hits          975      973       -2     
+ Misses         34       31       -3
Impacted Files Coverage Δ
lib/transform/canonical.js 86.57% <0.00%> (-0.09%) ⬇️
lib/index.js 95.83% <100.00%> (ø)
lib/transform/index.js 100.00% <100.00%> (+23.07%) ⬆️
lib/transform/standardize.js 98.03% <100.00%> (+0.01%) ⬆️
lib/util/convertDistance.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 267a120...e8a765b. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #44 (e8a765b) into 4-dev (267a120) will increase coverage by 0.28%.
The diff coverage is 97.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##            4-dev      #44      +/-   ##
==========================================
+ Coverage   96.63%   96.91%   +0.28%     
==========================================
  Files          33       33              
  Lines        1009     1004       -5     
==========================================
- Hits          975      973       -2     
+ Misses         34       31       -3
Impacted Files Coverage Δ
lib/transform/canonical.js 86.57% <0.00%> (-0.09%) ⬇️
lib/index.js 95.83% <100.00%> (ø)
lib/transform/index.js 100.00% <100.00%> (+23.07%) ⬆️
lib/transform/standardize.js 98.03% <100.00%> (+0.01%) ⬆️
lib/util/convertDistance.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 267a120...e8a765b. Read the comment docs.

@Aschen
Copy link
Contributor

Aschen commented May 26, 2021

Did you update the benchmark results ?
I'm curious about the performance gain here

@scottinet
Copy link
Contributor Author

scottinet commented May 26, 2021 •
edited
Loading

Yes I did, and there were no visible improvement. Which was to be expected: promises were used only for filters registrations.

@Aschen
Copy link
Contributor

Aschen commented May 26, 2021

Yes I did, and there were no visible improvement. Which was to be expected: promises were used only for filters registrations.

Yes but then there is no for filter registration? 🤔

@codecov
Copy link

codecov bot commented May 27, 2021 •
edited
Loading

Codecov Report

Merging #44 (e480420) into 4-dev (77e3925) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            4-dev      #44   +/-   ##
=======================================
  Coverage   96.91%   96.91%           
=======================================
  Files          33       33           
  Lines        1004     1004           
=======================================
  Hits          973      973           
  Misses         31       31
Impacted Files Coverage Δ
lib/util/convertDistance.js 100.00% <ø> (ø)
lib/index.js 95.83% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77e3925...e480420. Read the comment docs.

@scottinet scottinet merged commit 6ea7509 into 4-dev May 27, 2021
@scottinet scottinet deleted the remove-promises branch May 27, 2021 13:34
@scottinet scottinet mentioned this pull request Jun 16, 2021
Merged
scottinet added a commit that referenced this pull request Jun 16, 2021
@scottinet
Release 4.0.0 (#54)
b38b0c6 
# [4.0.0](https://github.com/kuzzleio/koncorde/releases/tag/4.0.0) (2021-06-16)


#### Breaking changes

- [ [#50](#50) ] Rename the maxMinterms configuration   ([scottinet](https://github.com/scottinet))
- [ [#45](#45) ] API revision   ([scottinet](https://github.com/scottinet))
- [ [#44](#44) ] Make the API synchronous   ([scottinet](https://github.com/scottinet))

#### New features

- [ [#49](#49) ] Improved errors thrown when parsing filters   ([scottinet](https://github.com/scottinet))
- [ [#46](#46) ] Add typescript interfaces   ([scottinet](https://github.com/scottinet))

#### Enhancements

- [ [#51](#51) ] Hash with SHA256 instead of Murmur3   ([scottinet](https://github.com/scottinet))

#### Optimizations

- [ [#47](#47) ] Change range checking library   ([scottinet](https://github.com/scottinet))
---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aschen Aschen Aschen approved these changes

@jenow jenow jenow approved these changes

Assignees

@scottinet scottinet

Labels
4.x changelog:breaking-changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scottinet @Aschen @jenow