Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept geopoints in string format #10

Merged
merged 1 commit into from
Mar 13, 2018
Merged

Conversation

scottinet
Copy link
Contributor

@scottinet scottinet commented Mar 9, 2018

Description

Makes Koncorde interpret geopoints coordinates provided as strings instead of numbers.

Filters provided to Koncorde with points in string format are now correctly converted. For instance, the following filter is now considered valid by the standardizer engine:

{
  "geoBoundingBox": {
    "someGeoPoint": {
      "topLeft": { "lat": "40.759507", "lon": "-73.985384" },
      "bottomRight": { "lat": "40.758372", "lon": "-73.984591" }
    }
  }
}

And Koncorde now tries correctly to match documents against registered filters when they contain geopoint in string format, such as:

{
  "someGeoPoint": {"lat": "40.769498", "lon": "-73.984609"}
}

Other changes

Updated modules dependencies

@scottinet scottinet self-assigned this Mar 9, 2018
@codecov-io
Copy link

codecov-io commented Mar 9, 2018

Codecov Report

Merging #10 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage   95.07%   95.15%   +0.08%     
==========================================
  Files          35       34       -1     
  Lines        1117     1115       -2     
==========================================
- Hits         1062     1061       -1     
+ Misses         55       54       -1
Impacted Files Coverage Δ
lib/transform/standardize.js 97.53% <100%> (+0.02%) ⬆️
lib/util/convertGeopoint.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf4a59b...f306fe3. Read the comment docs.

@ballinette ballinette merged commit f73d2ad into master Mar 13, 2018
@ballinette ballinette deleted the convert_points_to_float branch March 13, 2018 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants