Kzl 1154 ci build #320
Merged
Kzl 1154 ci build #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aschen
approved these changes
Jun 5, 2019
|
@benoitvidis We can even try node 11 or 12 no? |
benoitvidis
force-pushed
the
kzl-1154-ci-build
branch
from
949fa7d
to
154ba0d
Compare
xbill82
approved these changes
Jun 6, 2019
xbill82
reviewed
Jun 6, 2019
| "vuepress-plugin-container": "^2.0.1", | ||
| "vuepress-validate-frontmatter": "^2.0.10", | ||
| "yaml": "^1.5.1" | ||
| }, | ||
| "devDependencies": { | ||
| "colors": "^1.3.3", |
There was a problem hiding this comment.
This is a dependency for the current snippet test stack.
I don't know how this happened but it was previously registered in the package-lock.json but not in the package.json...
|
@Aschen , node 12 cannot be used as node-sass is not compatible with it yet. I tried node 11 and it does not change anything to the process time so I chose to stick to a LTS version. |
scottinet
approved these changes
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds automatic builds to documentation.
Builds will be deployed to https://docs.kuzzle.io when merged to
masterand to https://nex-docs.kuzzle.io on3-dev.Thanks to node 10 and possibly the upgrade of vuepress, the build can be generated in a relatively acceptable time (~35mn, i.e. https://travis-ci.org/kuzzleio/documentation/jobs/541275090).
Other changes
vuepressto 1.0.0-beta.1