Backtraces #3456
Merged
Backtraces #3456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminwinger
force-pushed
the
backtraces
branch
9 times, most recently
from
2c48dc1
to
e08ccb3
Compare
Currently does so by printing them in the exception constructor, as otherwise we wouldn't be able to check for expected query result messages. Also adds a std::terminate handler to handle some unexpected exits which would otherwise not print traces
benjaminwinger
force-pushed
the
backtraces
branch
from
b6c41fe
to
ce77b59
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3456 +/- ##
==========================================
- Coverage 92.59% 90.05% -2.54%
==========================================
Files 1205 1160 -45
Lines 44825 42357 -2468
==========================================
- Hits 41504 38144 -3360
- Misses 3321 4213 +892 ☔ View full report in Codecov by Sentry. |
4 tasks
ted-wq-x
pushed a commit
to ted-wq-x/kuzu
that referenced
this pull request
Nov 14, 2024
* Print backtraces when exceptions are thrown Currently does so by printing them in the exception constructor, as otherwise we wouldn't be able to check for expected query result messages. Also adds a std::terminate handler to handle some unexpected exits which would otherwise not print traces * Add support for SIGSEGV backtraces (and other signals) * Ignore false positive GCC warning in relwithdebinfo mode (cherry picked from commit 4e1a9fd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3053
(currently missing backtrace on segfaults).Everything is working except backtraces for segfaults on windows.Adds backtracing using cpptrace, and makes the default configuration for tests
RelWithDebInfo(otherwise the backtraces aren't very useful).Backtraces are being printed in the
kuzu::common::Exceptionconstructor since including them in the message will break the exception message tests. Unfortunately this does mean that the stack trace is printed before the exception, but is printed backwards with the expectation that it will be printed after the exception. It also means that exceptions which are handled and not re-thrown will also have their stack traces printed.Safe signal handling using a separate executable as described here was working, except that when it couldn't find the executable it would hang (in a suspiciously similar way to #3459, where only the scheduling thread can be interrupted in gdb). I thought that it might be more reliable just to use the unsafe
cpptrace::generate_trace().print(), and deal with the possibility of a CI job hanging on rare occasions (mostly it seems fine, but as far as I understand, major memory issues could cause various problems including hangs if we try and do complex stuff like memory allocation when handling the signal).