Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support read after update #3126

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Support read after update #3126

merged 1 commit into from
Mar 25, 2024

Conversation

andyfengHKU
Copy link
Contributor

@andyfengHKU andyfengHKU commented Mar 24, 2024

We now support read after update.

Since we already support read write in one transaction. There is no reason we couldn't support read after update in one plan. Also we need to enforce is that update pipeline is executed before read pipeline.

Copy link

codecov bot commented Mar 24, 2024

Codecov Report

Attention: Patch coverage is 92.45283% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 91.98%. Comparing base (a8b15dc) to head (c805aa7).

Files Patch % Lines
src/planner/operator/logical_operator.cpp 50.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3126   +/-   ##
=======================================
  Coverage   91.97%   91.98%           
=======================================
  Files        1171     1171           
  Lines       44027    44041   +14     
=======================================
+ Hits        40494    40509   +15     
+ Misses       3533     3532    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andyfengHKU andyfengHKU marked this pull request as ready for review March 24, 2024 19:40
src/include/planner/operator/logical_operator.h Outdated Show resolved Hide resolved
src/include/planner/operator/logical_operator.h Outdated Show resolved Hide resolved
src/planner/operator/logical_operator.cpp Outdated Show resolved Hide resolved
@andyfengHKU andyfengHKU merged commit 4d21128 into master Mar 25, 2024
17 checks passed
@andyfengHKU andyfengHKU deleted the read-after-update branch March 25, 2024 20:03
@andyfengHKU andyfengHKU mentioned this pull request Apr 15, 2024
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants