Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-write partitioner to use ColumnChunks instead of ValueVectors #2979

Merged
merged 1 commit into from
Mar 8, 2024

Re-write partitioner to use ColumnChunks instead of ValueVectors

38e4398
Select commit
Loading
Failed to load commit list.
Merged

Re-write partitioner to use ColumnChunks instead of ValueVectors #2979

Re-write partitioner to use ColumnChunks instead of ValueVectors
38e4398
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 8, 2024 in 0s

93.25% (target 80.00%)

View this Pull Request on Codecov

93.25% (target 80.00%)

Details

Codecov Report

Attention: Patch coverage is 89.37500% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 93.25%. Comparing base (5e598ec) to head (38e4398).

Files Patch % Lines
src/storage/store/column_chunk.cpp 67.44% 14 Missing ⚠️
src/storage/store/var_list_column_chunk.cpp 91.30% 2 Missing ⚠️
src/include/storage/store/node_group.h 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2979      +/-   ##
==========================================
- Coverage   93.31%   93.25%   -0.06%     
==========================================
  Files        1124     1124              
  Lines       42912    42934      +22     
==========================================
- Hits        40042    40040       -2     
- Misses       2870     2894      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.